Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add domain based module compatibility #1466

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat: add domain based module compatibility #1466

merged 1 commit into from
Sep 11, 2023

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Sep 5, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba requested a review from a team as a code owner September 5, 2023 14:09
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b85756d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/magento-api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bartoszherba bartoszherba force-pushed the feat/domain-based-multistore-compatibility branch from 64e40b9 to b85756d Compare September 6, 2023 10:54
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

[vuestorefront_magento2_api-client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

[vuestorefront_magento2_sdk] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bartoszherba bartoszherba merged commit a9ea521 into main Sep 11, 2023
10 checks passed
@bartoszherba bartoszherba deleted the feat/domain-based-multistore-compatibility branch September 11, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethidden sethidden sethidden approved these changes

@WojtekTheWebDev WojtekTheWebDev Awaiting requested review from WojtekTheWebDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartoszherba @sethidden @mirouse